Messages in this thread | | | Date | Fri, 24 Oct 2008 07:53:59 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: Adding kmap_atomic_prot_pfn (was: [git pull] drm patches for 2.6.27-rc1) |
| |
On Thu, 23 Oct 2008, Keith Packard wrote: > > I'm fine with sticking the mapping in a separate structure; it's just > the return from ioremap_wc on 64-bit systems, and nothing at all on > 32-bit systems.
Actually, on 32-bit, the 'prot' should be there, as should the starting physical page. Otherwise the two interfaces would be very odd, and you'd have to repeat those arguments in all callers (ie both in "prepare" and in the actual "access").
Linus
| |