lkml.org 
[lkml]   [2008]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 06/27] USB: dont rebind drivers after failed resume or reset
    2.6.27-stable review patch.  If anyone has any objections, please let us 
    know.

    ------------------
    From: Alan Stern <stern@rowland.harvard.edu>

    commit 6c6409459a18a825ce12ecb003d5686af61f7a2f upstream

    This patch (as1152) may help prevent some problems associated with the
    new policy of unbinding drivers that don't support suspend/resume or
    pre_reset/post_reset. If for any reason the resume or reset fails, and
    the device is logically disconnected, there's no point in trying to
    rebind the driver. So the patch checks for success before carrying
    out the unbind/rebind.

    There was a report from one user that this fixed a problem he was
    experiencing, but the details never became fully clear. In any case,
    adding these tests can't hurt.

    Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/usb/core/driver.c | 3 ++-
    drivers/usb/core/hub.c | 2 +-
    2 files changed, 3 insertions(+), 2 deletions(-)

    --- a/drivers/usb/core/driver.c
    +++ b/drivers/usb/core/driver.c
    @@ -1609,7 +1609,8 @@ int usb_external_resume_device(struct us
    status = usb_resume_both(udev);
    udev->last_busy = jiffies;
    usb_pm_unlock(udev);
    - do_unbind_rebind(udev, DO_REBIND);
    + if (status == 0)
    + do_unbind_rebind(udev, DO_REBIND);

    /* Now that the device is awake, we can start trying to autosuspend
    * it again. */
    --- a/drivers/usb/core/hub.c
    +++ b/drivers/usb/core/hub.c
    @@ -3424,7 +3424,7 @@ int usb_reset_device(struct usb_device *
    USB_INTERFACE_BOUND)
    rebind = 1;
    }
    - if (rebind)
    + if (ret == 0 && rebind)
    usb_rebind_intf(cintf);
    }
    }
    --


    \
     
     \ /
      Last update: 2008-10-24 06:43    [W:4.155 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site