lkml.org 
[lkml]   [2008]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 7/16 v6] PCI: cleanup pcibios_allocate_resources()
    On Thu, Oct 23, 2008 at 03:10:26PM +0800, Yinghai Lu wrote:
    > On Wed, Oct 22, 2008 at 1:42 AM, Yu Zhao <yu.zhao@intel.com> wrote:
    > > diff --git a/arch/x86/pci/i386.c b/arch/x86/pci/i386.c
    > > index 844df0c..8729bde 100644
    > > --- a/arch/x86/pci/i386.c
    > > +++ b/arch/x86/pci/i386.c
    > > @@ -147,7 +147,7 @@ static void __init pcibios_allocate_bus_resources(struct list_head *bus_list)
    > > static void __init pcibios_allocate_resources(int pass)
    > > {
    > > struct pci_dev *dev = NULL;
    > > - int idx, disabled;
    > > + int idx, enabled;
    > > u16 command;
    > > struct resource *r, *pr;
    > >
    > > @@ -160,22 +160,22 @@ static void __init pcibios_allocate_resources(int pass)
    > > if (!r->start) /* Address not assigned at all */
    > > continue;
    > > if (r->flags & IORESOURCE_IO)
    > > - disabled = !(command & PCI_COMMAND_IO);
    > > + enabled = command & PCI_COMMAND_IO;
    > > else
    > > - disabled = !(command & PCI_COMMAND_MEMORY);
    > > - if (pass == disabled) {
    > > - dev_dbg(&dev->dev, "resource %#08llx-%#08llx (f=%lx, d=%d, p=%d)\n",
    > > + enabled = command & PCI_COMMAND_MEMORY;
    > > + if (pass == enabled)
    > > + continue;
    >
    > it seems you change the flow here for MMIO
    > because PCI_COMMAND_MEMORY is 2.
    >
    > YH

    Nice finding! Will change it back to 'disable' next version.

    Thanks,
    Yu


    \
     
     \ /
      Last update: 2008-10-23 09:49    [W:0.022 / U:31.264 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site