lkml.org 
[lkml]   [2008]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pci: show dma_mask bits in /sys
On Wed, Oct 22, 2008 at 09:28:33PM -0600, Matthew Wilcox wrote:
> On Wed, Oct 22, 2008 at 06:45:10PM -0700, Yinghai Lu wrote:
> > Grant prefer to add it /sys instead of showing in bootlog
> >
> > so could catch if the driver set the correct dma_mask.
>
> I still don't think this is useful information to be exposing.

It's useful for anyone involved with device drivers - we agree that's
a very limited subset of users. I certainly get fed up with trying
to figure out which dma_mask each driver is using since in some
cases it might vary depending on which HW is installed and which
kernel is running.

If the /sys patch added a PCI_DEBUG option to the kernel,
would that work for you?
I'm not keen on that but just looking for alternatives.
Many other subsystems (SCSI, ACPI, PM, HID, ...) have a FOO_DEBUG option.

Lastly, /sys seems to have over run even /proc. On an rx2600 (ia64):
grundler@gsyprf3:/usr/src/linux-2.6$ find /sys ! -type d | wc
6288 6296 264893
grundler@gsyprf3:/usr/src/linux-2.6$ find /proc ! -type d | wc
find: `/proc/tty/driver': Permission denied
...
4104 4104 100797

Pruning some of the crap out of there sounds like another task suitable for
"kernel janitor" project.
/me runs and hides :)

thanks,
grant


\
 
 \ /
  Last update: 2008-10-23 08:47    [W:0.101 / U:28.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site