Messages in this thread | | | Date | Thu, 23 Oct 2008 18:37:02 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] tracing: fix a build error on alpha and m68k |
| |
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> When tracing is enabled, some arch have included <linux/irqflags.h> > on their <asm/system.h> but others like alpha or m68k don't. > > Build error on alpha: > > kernel/trace/trace.c: In function 'tracing_generic_entry_update': > kernel/trace/trace.c:658: error: implicit declaration of function 'irqs_disabled_flags' > kernel/trace/trace.c: In function 'tracing_cpumask_write': > kernel/trace/trace.c:2145: error: implicit declaration of function 'raw_local_irq_disable' > kernel/trace/trace.c:2162: error: implicit declaration of function 'raw_local_irq_enable' > kernel/trace/trace.c: In function 'trace_die_handler': > kernel/trace/trace.c:3039: error: 'DIE_OOPS' undeclared (first use in this function) > > Build error on m68k: > http://kisskb.ellerman.id.au/kisskb/buildresult/50641/ > > > Include it on kernel/trace/trace.c > > Reported-by: Alexey Dobriyan <adobriyan@gmail.com> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> > --- > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index 78d5661..deb9684 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -34,6 +34,7 @@ > > #include <linux/stacktrace.h> > #include <linux/ring_buffer.h> > +#include <linux/irqflags.h> > > #include "trace.h"
applied to tip/tracing/urgent, thanks!
Ingo
| |