lkml.org 
[lkml]   [2008]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Bug fix for pvrusb2 driver [was: Re: Kernel 2.6.26.5 -> 2.6.27.2 [USB REGRESSION] (USB -> D_STATE)]
On Mon, 20 Oct 2008, Greg KH wrote:

> On Mon, Oct 20, 2008 at 11:37:41AM -0500, Mike Isely wrote:
> >
> > I was incomplete in my previous response. See further below for nack
> > and another patch...
> >
> >
> > On Mon, 20 Oct 2008, Alan Stern wrote:
> >
> > [...]
> >
> > >
> > > Index: usb-2.6/drivers/media/video/pvrusb2/pvrusb2-main.c
> > > ===================================================================
> > > --- usb-2.6.orig/drivers/media/video/pvrusb2/pvrusb2-main.c
> > > +++ usb-2.6/drivers/media/video/pvrusb2/pvrusb2-main.c
> > > @@ -68,6 +68,16 @@ static void pvr_setup_attach(struct pvr2
> > > #endif /* CONFIG_VIDEO_PVRUSB2_SYSFS */
> > > }
> > >
> > > +static int pvr_pre_reset(struct usb_interface *intf)
> > > +{
> > > + return 0;
> > > +}
> > > +
> > > +static int pvr_post_reset(struct usb_interface *intf)
> > > +{
> > > + return 0;
> > > +}
> > > +
> > > static int pvr_probe(struct usb_interface *intf,
> > > const struct usb_device_id *devid)
> > > {
> > > @@ -109,7 +119,9 @@ static struct usb_driver pvr_driver = {
> > > .name = "pvrusb2",
> > > .id_table = pvr2_device_table,
> > > .probe = pvr_probe,
> > > - .disconnect = pvr_disconnect
> > > + .disconnect = pvr_disconnect,
> > > + .pre_reset = pvr_pre_reset,
> > > + .post_reset = pvr_post_reset,
> > > };
> > >
> > > /*
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > >
> >
> > Nacked-by: Mike Isely <isely@pobox.com>
> >
> > There is already another patch ready to go which eliminates the reset
> > entirely. It can be found here:
> >
> > http://linuxtv.org/hg/~mcisely/pvrusb2/rev/0bb411d8d2e4
>
> Will this patch be sent to the -stable group, to fix this regression in
> 2.6.27? Or should they take Alan's fix instead?
>

Greg:

I didn't directly answer your question here because I had figured it was
answered in a previous post on this thread, that Mike Krufky had already
explicitly asked that it be queued (and added his Reviewed-By tag), and
that I figured it best not to add yet more noise to an already noisy
group.

However now I see that this patch didn't get into 2.6.27.3. It's a
pretty important fix; without it the pvrusb2 driver is worse than
useless (unless one adds initusbreset=0 as a module option).

My POV for this process in the past is that I generate a stable fix at
linuxtv.org, ensure that Mike Krufky and Mauro see the incoming change,
and then it gets into the next stable release. This is what I thought I
did here, but the results are different - 2.6.27.3 still has the driver
in a totally broken state. Quite likely I missed something that caused
the fix not to be pulled. Is there anything I can do to ensure this get
into 2.6.27.4?

-Mike


--

Mike Isely
isely @ pobox (dot) com
PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8


\
 
 \ /
  Last update: 2008-10-23 18:31    [W:0.059 / U:3.440 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site