lkml.org 
[lkml]   [2008]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [bug #2] Re: [PATCH 00/35] cpumask: Replace cpumask_t with struct cpumask

* Mike Travis <travis@sgi.com> wrote:

> Rusty Russell wrote:
> > On Friday 24 October 2008 01:20:25 Ingo Molnar wrote:
> >> Thomas has started a -tip cross-build test, and there's massive
> >> cross-build failures as well due to the cpumask changes:
> >
> > Yes. linux-next reported the same thing. I've backed out various arch
> > changes for this reason.
> >
> >> it seems to me that this commit is massively borked:
> >>
> >> 4a792c2: cpumask: make CONFIG_NR_CPUS always valid
> >
> > Yep. This is the big one I dropped. There are a few others; Mike is just
> > porting the changes across to your tree now.
> >
> > Cheers,
> > Rusty.
>
> Hi Ingo,
>
> It would seem easier to back out previous patches and apply the
> replacements. Does this work for you?

no, it does not work fine. As i said, i reworked various small bits
along the way of reviewing and integrating them, under the obvious
assumption that you submitted the latest and greatest. I spent hours
testing every single step as well. If you cannot get your workflow right
then we cannot have this stuff in v2.6.28.

So ... please send append-only changes against tip/cpus4096-v2. We can
squash/backmerge any bits to keep it all clean, but all changes have to
be fully visible and fully reviewed from now on, because time is running
short.

Ingo


\
 
 \ /
  Last update: 2008-10-23 18:13    [W:0.605 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site