lkml.org 
[lkml]   [2008]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 00/13 v2] ftrace: clean ups and fixes

    On Thu, 23 Oct 2008, Wenji Huang wrote:

    > Hi,
    > just several trivial things.

    Thanks,

    >
    > [PATCH 02/13 v2] ftrace: dynamic ftrace process only text section
    > +# Acceptible sections to record.
    >
    > typo - Acceptible

    Ah, it should be Acceptable.

    >
    > [PATCH 03/13 v2] ftrace: return error on failed modified text.
    > + * This is a very sensitive operatation and great care needs
    >
    > typo - operatation

    Sorry, I must have stuttered ;-)

    > Why not put comments to function definition?

    The function is arch dependent. And the comment here is also to help
    the arch maintainers know what is needed of that function.

    >
    > [PATCH 04/13 v2] ftrace: comment arch ftrace code
    > + * as well as code changing. We do this by using the
    > + * __copy_*_user functions.
    >
    > According to [PATCH 05/13], change to using the proper API for reading and
    > writing, not __copy_*_user.

    Good catch. Thanks,

    -- Steve


    \
     
     \ /
      Last update: 2008-10-23 12:53    [W:0.033 / U:60.864 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site