lkml.org 
[lkml]   [2008]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 16/35] percpu: fix percpu accessors to potentially !cpu_possible() cpus From: Rusty Russell <>
    Percpu areas are only allocated for possible cpus.  In general, you
    shouldn't access random cpu's percpu areas: you're corrupting memory.

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    Signed-off-by: Mike Travis <travis@sgi.com>
    ---
    arch/m32r/kernel/smpboot.c | 2 +-
    arch/x86/mach-voyager/voyager_smp.c | 2 +-
    drivers/pnp/pnpbios/bioscalls.c | 2 +-
    3 files changed, 3 insertions(+), 3 deletions(-)

    --- linux-2.6.28.orig/arch/m32r/kernel/smpboot.c
    +++ linux-2.6.28/arch/m32r/kernel/smpboot.c
    @@ -592,7 +592,7 @@ int setup_profiling_timer(unsigned int m
    * accounting. At that time they also adjust their APIC timers
    * accordingly.
    */
    - for (i = 0; i < NR_CPUS; ++i)
    + for_each_possible_cpu(i)
    per_cpu(prof_multiplier, i) = multiplier;

    return 0;
    --- linux-2.6.28.orig/arch/x86/mach-voyager/voyager_smp.c
    +++ linux-2.6.28/arch/x86/mach-voyager/voyager_smp.c
    @@ -1216,7 +1216,7 @@ int setup_profiling_timer(unsigned int m
    * new values until the next timer interrupt in which they do process
    * accounting.
    */
    - for (i = 0; i < NR_CPUS; ++i)
    + for_each_possible_cpu(i)
    per_cpu(prof_multiplier, i) = multiplier;

    return 0;
    --- linux-2.6.28.orig/drivers/pnp/pnpbios/bioscalls.c
    +++ linux-2.6.28/drivers/pnp/pnpbios/bioscalls.c
    @@ -481,7 +481,7 @@ void pnpbios_calls_init(union pnp_bios_i

    set_base(bad_bios_desc, __va((unsigned long)0x40 << 4));
    _set_limit((char *)&bad_bios_desc, 4095 - (0x40 << 4));
    - for (i = 0; i < NR_CPUS; i++) {
    + for_each_possible_cpu(i) {
    struct desc_struct *gdt = get_cpu_gdt_table(i);
    if (!gdt)
    continue;
    --


    \
     
     \ /
      Last update: 2008-10-23 04:15    [W:0.022 / U:30.884 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site