lkml.org 
[lkml]   [2008]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Skip tsc synchronization checks if CONSTANT_TSC bit is set.

* Alok Kataria <akataria@vmware.com> wrote:

> Skip tsc synchronization checks if CONSTANT_TSC bit is set.
>
> From: Alok N Kataria <akataria@vmware.com>
>
> TSC synchronization checks between CPU's bail out even if we see a
> distortion of a single cycle. This makes the TSC mostly unsuable in a
> virtualized environment.
>
> The CONSTANT_TSC bit tells us if the hardware exports a constant TSC,
> we can use this bit to trust the hardware and skip the TSC sync checks
> at bootup.

the sync check is there to check the _offset_ between CPUs. CONSTANT_TSC
is not a guarantee that the TSC will be coherent across all CPUs.

so this patch is fundamentally wrong.

Ingo


\
 
 \ /
  Last update: 2008-10-22 21:29    [W:0.085 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site