lkml.org 
[lkml]   [2008]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/11] ftrace: return error on failed modified text.

On Wed, 22 Oct 2008, Andrew Morton wrote:

> On Wed, 22 Oct 2008 14:43:16 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > Return -1 on failed modified text.
> >
>
> changelog fails to explain the reason for the change.
>
> > + if (__copy_to_user_inatomic((char __user *)ip, new_code,
> > + MCOUNT_INSN_SIZE))
> > + return -1;
>
> why not -EFAULT?

Indeed, why not. I'll update it in v2.

-- Steve



\
 
 \ /
  Last update: 2008-10-22 21:07    [W:0.041 / U:1.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site