lkml.org 
[lkml]   [2008]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip] x86: do_boot_cpu - check if we have ESR register

* Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> [Ingo Molnar - Wed, Oct 22, 2008 at 04:59:09PM +0200]
> |
> | > > | > - apic_write(APIC_ESR, 0);
> | > > | > - apic_read(APIC_ESR);
> | > > | > + if (APIC_INTEGRATED(apic_version[phys_apicid])) {
> | > > | > + apic_write(APIC_ESR, 0);
> | > > | > + apic_read(APIC_ESR);
> | > > | > + }
> |
> | this wouldnt build with certain configs:
> |
> | arch/x86/kernel/smpboot.c: In function 'do_boot_cpu':
> | arch/x86/kernel/smpboot.c:897: error: 'phys_apicid' undeclared (first use in this function)
> | arch/x86/kernel/smpboot.c:897: error: (Each undeclared identifier is reported only once
> | arch/x86/kernel/smpboot.c:897: error: for each function it appears in.)
> | include/asm/io_32.h: In function 'memcpy_fromio':
> |
> | because phys_apicid is not available in the !WAKE_SECONDARY_VIA_INIT
> | case. Changed it to boot_cpu_physical_apicid - that should be good
> | enough.
> |
> | Ingo
> |
>
> Did you fixed it? (oh... actually I've been compilling the patch
> but had this CONFIG turned on and didn't catch this issue)

yeah, fixed it up, dont worry about it.

Ingo


\
 
 \ /
  Last update: 2008-10-22 17:07    [W:0.045 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site