lkml.org 
[lkml]   [2008]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sound: correct bracketing in spdif test
At Tue, 21 Oct 2008 23:38:31 -0400,
Matthew Ranostay wrote:
>
> Harvey Harrison wrote:
> > Noticed by sparse:
> > sound/pci/hda/patch_sigmatel.c:1285:43: warning: dubious: !x & y
> >
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > ---
> > sound/pci/hda/patch_sigmatel.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> > index a2ac720..788fdc6 100644
> > --- a/sound/pci/hda/patch_sigmatel.c
> > +++ b/sound/pci/hda/patch_sigmatel.c
> > @@ -1282,7 +1282,7 @@ static int stac92xx_build_controls(struct hda_codec *codec)
> > return err;
> > spec->multiout.share_spdif = 1;
> > }
> > - if (spec->dig_in_nid && (!spec->gpio_dir & 0x01)) {
> > + if (spec->dig_in_nid && !(spec->gpio_dir & 0x01)) {
> > err = snd_hda_create_spdif_in_ctls(codec, spec->dig_in_nid);
> > if (err < 0)
> > return err;
>
> Thanks for finding this.
>
>
> Acked-by: Matthew Ranostay <mranostay@embeddedalley.com>

Applied now. Thanks!

Takashi


\
 
 \ /
  Last update: 2008-10-22 08:05    [W:0.027 / U:4.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site