[lkml]   [2008]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] x86: remove superfluous dmi_ignore_irq0_timer_override quirks

* Andreas Herrmann <> wrote:

> The problem should be solved with commits:
> x86: SB600: skip IRQ0 override if it is not routed to INT2 of IOAPIC
> x86: SB450: skip IRQ0 override if it is not routed to INT2 of IOAPIC
> IMHO it does not make sense to check within a dmi-quirk
> whether an early-quirk was applied. Boot sequence is as follows:
> acpi_boot_table_init() (it applies dmi-quirks)
> ...
> early_quirks() (detect bogus IRQ0 override)
> ...
> acpi_boot_init() (setup IO APIC)
> Thus with current code we will always get following warnings for
> Laptops that have this dmi_ignore_irq0_timer_override dmi quirk:
> WARNING: at arch/x86/kernel/acpi/boot.c:1410
> dmi_ignore_irq0_timer_override+0x30/0x60()
> ati_ixp4x0 quirk not complete.
> ... just because the early-quirk (ati_ixp4x0) was not yet executed.

could we move the DMI check to after the early quicks stage? It would be
nice to have this double check, for at least one kernel cycle.


 \ /
  Last update: 2008-10-22 12:05    [W:0.041 / U:6.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site