lkml.org 
[lkml]   [2008]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH,RFC] ext3: Add support for non-native signed/unsigned htree hash algorithms
Date
On Monday 20 October 2008 20:43, Theodore Ts'o wrote:
> +static __u32 dx_hack_hash (const char *name, int len, int unsigned_flag)
> ...
> + if (unsigned_flag)
> + c = (int) *ucp++;
> + else
> + c = (int) *scp++;

This being a high performance hash function and all, why not something
like:

+static __u32 uchar_hack_hash (const char *name, int len)
+...

+static __u32 char_hack_hash (const char *name, int len)
+...

+static __u32 dx_hack_hash(const char *name, int len, int unsigned_flag)
+{
+ if (unsigned_flag)
+ return uchar_hack_hash(name, len);
+ return char_hack_hash(name, len);
+}


\
 
 \ /
  Last update: 2008-10-21 23:53    [W:0.161 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site