lkml.org 
[lkml]   [2008]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/7] kgdboc, tty: use tty open to start low level drivers
Jason Wessel wrote:
> A few minor changes were needed in tty_io.c to deal with the fact that
> the inode and fpath.dentry were NULL with the generic flip structure.
>

After further testing and review one patch hunk has been eliminated.

> Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
> ---
> drivers/char/tty_io.c | 96 +++++++++++++++++++++++++++++++++++++++++---
> drivers/serial/kgdboc.c | 26 ++++++++----
> include/linux/tty_driver.h | 5 ++
> 3 files changed, 113 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
> index fa44e6b..fe500ec 100644
> --- a/drivers/char/tty_io.c
> +++ b/drivers/char/tty_io.c
> @@ -1723,7 +1806,7 @@ void tty_release_dev(struct file *filp)
> release_tty(tty, idx);
>
> /* Make this pty number available for reallocation */
> - if (devpts)
> + if (devpts && inode)
> devpts_kill_index(inode, idx);
> }
>

Specifically the call to devpts_kill_index() should get executed
and the above patch hunk has been removed.

Thanks,
Jason.


\
 
 \ /
  Last update: 2008-10-21 23:51    [W:0.100 / U:2.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site