Messages in this thread | | | Date | Tue, 21 Oct 2008 05:28:43 -0700 | From | Mike Travis <> | Subject | Re: [PATCH 01/35] x86: clean up speedctep-centrino and reduce cpumask_t usage |
| |
Stephen Rothwell wrote: > Hi Mike, > > Just a first small thing: > > On Mon, 20 Oct 2008 10:03:20 -0700 Mike Travis <travis@sgi.com> wrote: >> 1) The #ifdef CONFIG_HOTPLUG_CPU seems unnecessary these days. >> 2) The loop can simply skip over offline cpus, rather than creating a tmp mask. >> 3) set_mask is set to either a single cpu or all online cpus in a policy. >> Since it's just used for set_cpus_allowed(), any offline cpus in a policy >> don't matter, so we can just use cpumask_of_cpu() or the policy->cpus. >> >> From: Rusty Russell <rusty@rustcorp.com.au> >> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> >> Signed-off-by: Mike Travis <travis@sgi.com> > > The From: line should be the first nonempty line in the mail to get the > attribution correct. >
Ahh, ok, thanks!
| |