Messages in this thread | | | Date | Tue, 21 Oct 2008 14:07:20 +0200 | From | Andi Kleen <> | Subject | Re: [announce] new tree: "fix all build warnings, on all configs" |
| |
On Tue, Oct 21, 2008 at 01:17:16PM +0200, Ingo Molnar wrote: > > * Andi Kleen <andi@firstfloor.org> wrote: > > > > * acpi_pm_disable_gpes - Disable the GPEs. > > > */ > > > -static int acpi_pm_disable_gpes(void) > > > +static inline int acpi_pm_disable_gpes(void) > > > > Just to satisfy my curiosity, what compiler warning does marking > > functions inline fix? > > the commit log below explains the situation. The warning exposed a maze > of #ifdefs in drivers/acpi/sleep/main.c. It's not the warning we need to > "fix" but that maze, obviously.
Thanks. That makes sense,
I also agree with you that the better alternative would be to just always force SUSPEND together with ACPI.
I suspect the code delta wouldn't be very large compared to the rest of the ACPI code.
-Andi
| |