[lkml]   [2008]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] x86, ioremap: use %pR in printk
    On Mon, 2008-10-20 at 09:12 +0200, Ingo Molnar wrote:
    > * Benjamin Herrenschmidt <> wrote:
    > > This converts things in drivers/pci to use %pR to printout the
    > > content of a struct resource instead of hand-casted %llx or
    > > other variants.
    > >
    > > Signed-off-by: Benjamin Herrenschmidt <>
    > cool!
    > Acked-by: Ingo Molnar <>
    > there's also two places in arch/x86/mm/ioremap.c that could use this
    > straight away - see the (untested) patch below.

    No, you don't pass it a phys_addr_t or a resource_size_t, you pass it a
    struct resource *

    Now, I would have liked to have a way to print a resource_size_t (or
    phys_addr_t) but that's harder because we need pointers for the magic
    typechecking to work (among others).

    Maybe we could create a special format for a pointer-to-resource_size_t
    and pass &foo on callers but that's fishy...


     \ /
      Last update: 2008-10-20 10:39    [W:0.034 / U:58.304 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site