Messages in this thread | | | Date | Mon, 20 Oct 2008 11:37:41 -0500 (CDT) | From | Mike Isely <> | Subject | Re: Bug fix for pvrusb2 driver [was: Re: Kernel 2.6.26.5 -> 2.6.27.2 [USB REGRESSION] (USB -> D_STATE)] |
| |
I was incomplete in my previous response. See further below for nack and another patch...
On Mon, 20 Oct 2008, Alan Stern wrote:
[...]
> > Index: usb-2.6/drivers/media/video/pvrusb2/pvrusb2-main.c > =================================================================== > --- usb-2.6.orig/drivers/media/video/pvrusb2/pvrusb2-main.c > +++ usb-2.6/drivers/media/video/pvrusb2/pvrusb2-main.c > @@ -68,6 +68,16 @@ static void pvr_setup_attach(struct pvr2 > #endif /* CONFIG_VIDEO_PVRUSB2_SYSFS */ > } > > +static int pvr_pre_reset(struct usb_interface *intf) > +{ > + return 0; > +} > + > +static int pvr_post_reset(struct usb_interface *intf) > +{ > + return 0; > +} > + > static int pvr_probe(struct usb_interface *intf, > const struct usb_device_id *devid) > { > @@ -109,7 +119,9 @@ static struct usb_driver pvr_driver = { > .name = "pvrusb2", > .id_table = pvr2_device_table, > .probe = pvr_probe, > - .disconnect = pvr_disconnect > + .disconnect = pvr_disconnect, > + .pre_reset = pvr_pre_reset, > + .post_reset = pvr_post_reset, > }; > > /* > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
Nacked-by: Mike Isely <isely@pobox.com>
There is already another patch ready to go which eliminates the reset entirely. It can be found here:
http://linuxtv.org/hg/~mcisely/pvrusb2/rev/0bb411d8d2e4
-Mike
--
Mike Isely isely @ pobox (dot) com PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8
| |