lkml.org 
[lkml]   [2008]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Breaks the redundant loop in kernel/marker.c
* Ingo Molnar (mingo@elte.hu) wrote:
>
> * Zhaolei <zhaolei@cn.fujitsu.com> wrote:
>
> > Ingo Molnar wrote:
> > > hm, could you describe the necessity of this patch some more? This has
> > > the change to change behavior, which might even be a bugfix: is there
> > > any chance that the closure-loop in the e->ptype != NULL branch does not
> > > exit? Before your patch we'd continue the iteration - which _probably_
> > > does not lead to any more matches (e->name is supposed to be unique).
> >
> > Because e->name is unique in list, we don't need to continue the iteration
> > after matched.
> > This is a cleanup.
>
> ok - it's useful to point this out in the changelog. You can use the
> "Impact:" header we started using recently:
>
> Impact: cleanup, no functionality changed
>
> See for example this upstream commit:
>
> | commit 07454bfff151d2465ada809bbaddf3548cc1097c
> | Author: Thomas Gleixner <tglx@linutronix.de>
> | Date: Sat Oct 4 10:51:07 2008 +0200
> |
> | clockevents: check broadcast tick device not the clock events device
> |
> | Impact: jiffies increment too fast.
>
> Mathieu, any objections against the patch?
>
> Ingo

It looks all good with an extended changelog.

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>

Thanks,

Mathieu

--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68


\
 
 \ /
  Last update: 2008-10-20 17:41    [W:0.815 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site