lkml.org 
[lkml]   [2008]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] ring_buffer: map to cpu not page

    My original patch had a compile bug when NUMA was configured. I
    referenced cpu when it should have been cpu_buffer->cpu.

    Ingo quickly fixed this bug by replacing cpu with 'i' because that
    was the loop counter. Unfortunately, the 'i' was the counter of
    pages, not CPUs. This caused a crash when the number of pages allocated
    for the buffers exceeded the number of pages, which would usually
    be the case.

    Signed-off-by: Steven Rostedt <srostedt@redhat.com>
    ---
    kernel/trace/ring_buffer.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    Index: linux-tip.git/kernel/trace/ring_buffer.c
    ===================================================================
    --- linux-tip.git.orig/kernel/trace/ring_buffer.c 2008-10-02 09:09:01.000000000 -0400
    +++ linux-tip.git/kernel/trace/ring_buffer.c 2008-10-02 18:58:44.000000000 -0400
    @@ -232,7 +232,7 @@ static int rb_allocate_pages(struct ring

    for (i = 0; i < nr_pages; i++) {
    page = kzalloc_node(ALIGN(sizeof(*page), cache_line_size()),
    - GFP_KERNEL, cpu_to_node(i));
    + GFP_KERNEL, cpu_to_node(cpu_buffer->cpu));
    if (!page)
    goto free_pages;
    list_add(&page->list, &pages);



    \
     
     \ /
      Last update: 2008-10-03 01:21    [W:0.021 / U:92.368 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site