lkml.org 
[lkml]   [2008]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] xen: nuke the ballon files

On Thu, 2 Oct 2008, Jeremy Fitzhardinge wrote:

> Steven Rostedt wrote:
> > Investigating the unused static files in the balloon code, I discovered
> > that the balloon code is not used at all.
> >
> > The header file is one big #if 0 and all the functions in the C file
> > is static. There is no caller like init_module to hook to any of
> > these functions. Basically, this code is one big patch of dead code
> > wasting space on my hard drive.
> >
> > This patch removes the balloon code altogether since there are no
> > users.
> >
>
> Er, I think you should back away from that crack pipe.

No, coffee is my drug of choice. I did have a bit of overdose today ;-)

>
> > -subsys_initcall(balloon_init);

Ouch! How did I miss that.

Anyway, there are still a bunch of functions in that code that are not
referenced. OK, nack this patch, but could you please supply one that
cleans that code up.

Thanks,

-- Steve



\
 
 \ /
  Last update: 2008-10-02 20:03    [W:0.059 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site