Messages in this thread | | | Date | Sat, 18 Oct 2008 01:13:14 +0400 | From | Anton Vorontsov <> | Subject | Re: [PATCH 5/7] of/gpio: implement of_dev_gpiochip_{add,remove} calls |
| |
On Fri, Oct 17, 2008 at 01:25:01PM -0700, David Brownell wrote: > On Thursday 16 October 2008, Anton Vorontsov wrote: > > + if (of_gc->chip) > > + return of_gc->chip; > > + return &of_gc->gc; > > presumably there's a reason not to > > of_gc->chip = &of_gc->gc;
Yes, there are two reasons:
1. I need some place to insert the huge comment, which you snipped. ;-)
2. I didn't want to break current users. That is, the line you purpose ("of_gc->chip = &of_gc->gc;") should be inserted to every of_gpio controller. Most of them use of_mm_gpiochip_add(), so these are easy. But some (mcu_mpc8349emitx.c) are doing things by themselves.
Thanks,
-- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |