lkml.org 
[lkml]   [2008]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix broken debug output reserve_region_with_split()


On Fri, 17 Oct 2008, Benjamin Herrenschmidt wrote:
>
> +#ifdef CONFIG_PHYS_ADDR_T_64BIT
> +#define MEM_RSRC_SIZE 16
> +#else
> +#define MEM_RSRC_SIZE 8
> +#endif
> +
> +#ifdef CONFIG_X86
> +#define IO_RSRC_SIZE 4
> +#elif CONFIG_PPC
> +#define IO_RSRC_SIZE 8
> +#else
> +#define IO_RSRC_SIZE MEM_RSRC_SIZE
> +#endif

Why?

Do you think alpha wants to see its PIO resources shown as

[00000000000001f0-00000000000001f7]

or

[01f0-01f7]

and which do you think is more readable?

And even on sparc, with the full 64 bits in use, it's not like we'd be
*truncating* to 4 hex digits with %04x.

Linus


\
 
 \ /
  Last update: 2008-10-17 18:01    [W:0.134 / U:5.888 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site