Messages in this thread | | | Date | Fri, 17 Oct 2008 21:10:07 +0600 | From | "Rakib Mullick" <> | Subject | Re: [PATCH] init: Properly placing noinline keyword. |
| |
On 10/17/08, Américo Wang <xiyou.wangcong@gmail.com> wrote: > On Fri, Oct 17, 2008 at 08:17:33PM +0600, Rakib Mullick wrote: > >On 10/17/08, Alexey Dobriyan <adobriyan@gmail.com> wrote: > >> On Fri, Oct 17, 2008 at 07:05:32PM +0600, Rakib Mullick wrote: > >> > Here, noinline keyword should be placed between storage class and type. > >> > >> > >> Why? > >Because, scripts/checkpatch.pl warned with following warning: > > ERROR: inline keyword should sit between storage class and type > > > Well, 'noinline' is different from 'inline'. > > 'noinline' is defined as: > > #define noinline __attribute__((noinline)) > > in include/linux/compiler-gcc.h. But 'inline' is a _keyword_ defined > by C standard. If checkpatch.pl complains about 'noinline', you should > fix checkpatch.pl. :) Thanks, for explanation. But isn't it nice to place it between storage class and type ? > > > -- > "Sometimes the only way to stay sane is to go a little crazy." > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |