lkml.org 
[lkml]   [2008]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[patch 07/24] perfmon3: X86 OProfile hooks
From
Date
Provides PMU access synchronization between Perfmon and OProfile.
Both subsystems can be compiled in. Only one of them can be active
at any one time. It is necessary to issue opcontrol --shutdown
to terminate the OProfile session.

Signed-off-by: Stephane Eranian <eranian@gmail.com>

--

Index: o3/arch/x86/oprofile/nmi_int.c
===================================================================
--- o3.orig/arch/x86/oprofile/nmi_int.c 2008-10-15 15:53:25.000000000 +0200
+++ o3/arch/x86/oprofile/nmi_int.c 2008-10-15 15:53:27.000000000 +0200
@@ -16,6 +16,7 @@
#include <linux/moduleparam.h>
#include <linux/kdebug.h>
#include <linux/cpu.h>
+#include <linux/perfmon_kern.h>
#include <asm/nmi.h>
#include <asm/msr.h>
#include <asm/apic.h>
@@ -217,12 +218,18 @@
int err = 0;
int cpu;

- if (!allocate_msrs())
+ if (pfm_session_allcpus_acquire())
+ return -EBUSY;
+
+ if (!allocate_msrs()) {
+ pfm_session_allcpus_release();
return -ENOMEM;
+ }

err = register_die_notifier(&profile_exceptions_nb);
if (err) {
free_msrs();
+ pfm_session_allcpus_release();
return err;
}

@@ -303,6 +310,7 @@
msrs = &get_cpu_var(cpu_msrs);
model->shutdown(msrs);
free_msrs();
+ pfm_session_allcpus_release();
put_cpu_var(cpu_msrs);
}

Index: o3/include/linux/perfmon_kern.h
===================================================================
--- o3.orig/include/linux/perfmon_kern.h 2008-10-15 15:53:25.000000000 +0200
+++ o3/include/linux/perfmon_kern.h 2008-10-15 15:53:27.000000000 +0200
@@ -192,6 +192,9 @@

void pfm_interrupt_handler(unsigned long ip, struct pt_regs *regs);

+int pfm_session_allcpus_acquire(void);
+void pfm_session_allcpus_release(void);
+
static inline void pfm_exit_thread(void)
{
if (current->pfm_context)
@@ -272,5 +275,13 @@

static inline void pfm_ctxsw_out(struct task_struct *p, struct task_struct *n)
{}
+
+static inline void pfm_session_allcpus_release(void)
+{}
+
+static inline int pfm_session_allcpus_acquire(void)
+{
+ return 0;
+}
#endif /* CONFIG_PERFMON */
#endif /* __LINUX_PERFMON_KERN_H__ */
Index: o3/perfmon/perfmon_res.c
===================================================================
--- o3.orig/perfmon/perfmon_res.c 2008-10-15 15:53:25.000000000 +0200
+++ o3/perfmon/perfmon_res.c 2008-10-15 15:53:27.000000000 +0200
@@ -36,6 +36,7 @@
* 02111-1307 USA
*/
#include <linux/kernel.h>
+#include <linux/module.h>
#include <linux/perfmon_kern.h>
#include "perfmon_priv.h"

@@ -103,3 +104,87 @@

spin_unlock_irqrestore(&pfm_res_lock, flags);
}
+
+/**
+ * pfm_session_allcpus_acquire - acquire per-cpu sessions on all available cpus
+ *
+ * currently used by Oprofile on X86
+ */
+int pfm_session_allcpus_acquire(void)
+{
+ unsigned long flags;
+ u32 nsys_cpus, cpu;
+ int ret = -EBUSY;
+
+ spin_lock_irqsave(&pfm_res_lock, flags);
+
+ nsys_cpus = cpus_weight(pfm_res.sys_cpumask);
+
+ PFM_DBG("in sys=%u task=%u",
+ nsys_cpus,
+ pfm_res.thread_sessions);
+
+ if (nsys_cpus) {
+ PFM_DBG("already some system-wide sessions");
+ goto abort;
+ }
+
+ /*
+ * cannot mix system wide and per-task sessions
+ */
+ if (pfm_res.thread_sessions) {
+ PFM_DBG("%u conflicting thread_sessions",
+ pfm_res.thread_sessions);
+ goto abort;
+ }
+
+ for_each_online_cpu(cpu) {
+ cpu_set(cpu, pfm_res.sys_cpumask);
+ nsys_cpus++;
+ }
+
+ PFM_DBG("out sys=%u task=%u",
+ nsys_cpus,
+ pfm_res.thread_sessions);
+
+ ret = 0;
+abort:
+ spin_unlock_irqrestore(&pfm_res_lock, flags);
+
+ return ret;
+}
+EXPORT_SYMBOL(pfm_session_allcpus_acquire);
+
+/**
+ * pfm_session_allcpus_release - relase per-cpu sessions on all cpus
+ *
+ * currently used by Oprofile code
+ */
+void pfm_session_allcpus_release(void)
+{
+ unsigned long flags;
+ u32 nsys_cpus, cpu;
+
+ spin_lock_irqsave(&pfm_res_lock, flags);
+
+ nsys_cpus = cpus_weight(pfm_res.sys_cpumask);
+
+ PFM_DBG("in sys=%u task=%u",
+ nsys_cpus,
+ pfm_res.thread_sessions);
+
+ /*
+ * XXX: could use __cpus_clear() with nbits
+ */
+ for_each_online_cpu(cpu) {
+ cpu_clear(cpu, pfm_res.sys_cpumask);
+ nsys_cpus--;
+ }
+
+ PFM_DBG("out sys=%u task=%u",
+ nsys_cpus,
+ pfm_res.thread_sessions);
+
+ spin_unlock_irqrestore(&pfm_res_lock, flags);
+}
+EXPORT_SYMBOL(pfm_session_allcpus_release);
--



\
 
 \ /
  Last update: 2008-10-17 17:11    [W:0.048 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site