lkml.org 
[lkml]   [2008]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Enable console on PCI serial devices
Date
On Friday 17 October 2008 08:11:02 am n0ano@n0ano.com wrote:
> On Fri, Oct 17, 2008 at 10:28:58AM +0100, Alan Cox wrote:
> > Different discussion and different patches. We can get patches in for the
> > crystal frequency stuff and then debate the rest later
>
> In that case, here is the crystal frequency patch (typos fixed and
> proper sign off line).

I like this patch, except ...

> + "options" are the same as for ttyS, above. "clk"
> + is the crystal frequency which defaults to 115200
> + (typically the fastest baud rate supported by the
> + uart) but some hardware use different crystals.

this text is a little confusing. Since you multiply by 16 below, the
number specified by the user isn't really the crystal frequency, is it?

> + options = strchr(options, ',');
> + if (options) {
> + options++;
> + port->uartclk = simple_strtoul(options, NULL, 0) * 16;
> + }


\
 
 \ /
  Last update: 2008-10-17 16:49    [W:0.080 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site