Messages in this thread | | | Date | Fri, 17 Oct 2008 09:09:01 -0400 | From | Josh Boyer <> | Subject | Re: [PATCH] ibm_newemac: Fix new MAL feature handling |
| |
On Fri, 17 Oct 2008 14:56:52 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
> On Thursday 16 October 2008, Josh Boyer wrote: > > +#ifdef CONFIG_PPC_DCR_NATIVE > > if (mal_has_feature(mal, MAL_FTR_CLEAR_ICINTSTAT)) > > mtdcri(SDR0, DCRN_SDR_ICINTSTAT, > > (mfdcri(SDR0, DCRN_SDR_ICINTSTAT) | ICINTSTAT_ICTX)); > > +#endif > > > > So what if you have a mmio based DRC implementation and still want to use > this feature?
You have to have hardware that does that. When it exists, we can probably worry about it. Hopefully that will never happen. (Axon is an abomination that should not be repeated.)
> I guess you really should use dcr_read/dcr_write here instead of mtdcr/mfdcr.
We can look at that. It's not going to be high on my TODO list at the moment though. (hint, there are other places that do the same thing here and they should all be cleaned up if we're going to bother.)
josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |