lkml.org 
[lkml]   [2008]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH 2/2] cciss: fix regression in procfs display fw version, obsoletes previous patch 2 of 2
> > > +     return_code = sendcmd_withirq(CISS_INQUIRY, i, inq_buff,
> > > > + sizeof(InquiryData_struct), 0, 0 ,0, TYPE_CMD);
> > > > + if (return_code == IO_OK) {
> > > > + hba[i]->firm_ver[0] = inq_buff->data_byte[32];
> > > > + hba[i]->firm_ver[1] = inq_buff->data_byte[33];
> > > > + hba[i]->firm_ver[2] = inq_buff->data_byte[34];
> > > > + hba[i]->firm_ver[3] = inq_buff->data_byte[35];
> > > > + } else { /* send command failed */
> > > > + printk(KERN_WARNING "cciss: unable to
> > > determine firmware"
> > > > + " version of controller\n");
> > > > + }
> > > > +
> > > > cciss_procinit(i);
> > > >
> > > > hba[i]->cciss_max_sectors = 2048;
> >
> > Sorry, in too much of a hurry. I'll fix (again).
>
> And inq_buff is leaked, if I'm not missing simething.
>
Sorry, Alexy, I can't see the leak. Is it in the failure case?


\
 
 \ /
  Last update: 2008-10-17 01:01    [W:0.049 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site