lkml.org 
[lkml]   [2008]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] mm: rework do_pages_move() to work on page_sized chunks
Christoph Lameter wrote:
>> + err = -ENOMEM;
>> + pm = kmalloc(PAGE_SIZE, GFP_KERNEL);
>> + if (!pm)
>>
>
> ok.... But if you need a page sized chunk then you can also do
> get_zeroed_page(GFP_KERNEL). Why bother the slab allocator for page sized
> allocations?
>

Right. But why get_zeroed_page()? I don't think I need anything zeroed
(and I needed so, I would have to zero again between each chunk).

alloc_pages(order=0)+__free_pages() is probably good.

>> + /* fill the chunk pm with addrs and nodes from user-space */
>> + for (j = 0; j < chunk_nr_pages; j++) {
>>
>
> j? So the chunk_start used to be i?
>

The original "i" is somehow "chunk_start+j" now.

Thanks Christoph, I'll send an updated "4/5" patch in the next days.

Brice



\
 
 \ /
  Last update: 2008-10-16 23:21    [W:0.148 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site