lkml.org 
[lkml]   [2008]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 72/80] tty: fix up gigaset a bit
    Am 13.10.2008 11:44 schrieb Alan Cox:
    > From: Alan Cox <alan@redhat.com>
    >
    > Stephen's fixes reminded me that gigaset is still rather broken so fix it up
    > a bit
    >
    > Signed-off-by: Alan Cox <alan@redhat.com>

    Acked-by: Tilman Schmidt <tilman@imap.cc>

    Thanks, Alan, for these improvements.
    I'm now looking into the FIXME comments you added.

    > @@ -571,6 +571,7 @@ gigaset_tty_close(struct tty_struct *tty)
    > }
    >
    > /* prevent other callers from entering ldisc methods */
    > + /* FIXME: should use the tty state flags */
    > tty->disc_data = NULL;
    >
    > if (!cs->hw.ser)

    Do you know of an example line discipline that has got this right?
    My model for this code was drivers/net/ppp_async.c but now it seems
    that this was not as exemplary as I had hoped.

    > @@ -680,6 +675,8 @@ gigaset_tty_ioctl(struct tty_struct *tty, struct file *file,
    > /*
    > * Poll on the tty.
    > * Unused, always return zero.
    > + *
    > + * FIXME: should probably return an exception - especially on hangup
    > */
    > static unsigned int
    > gigaset_tty_poll(struct tty_struct *tty, struct file *file, poll_table *wait)

    Looking around, I see that many LDs don't even provide a poll method.
    So I'm thinking of just dropping this one. Would that be ok?

    Thanks,
    Tilman

    --
    Tilman Schmidt E-Mail: tilman@imap.cc
    Bonn, Germany
    Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
    Ungeöffnet mindestens haltbar bis: (siehe Rückseite)

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2008-10-16 17:53    [W:5.211 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site