[lkml]   [2008]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] sparc64: Annotate pointers in PeeCeeI.c
On Wed, 2008-10-15 at 17:23 -0700, David Miller wrote:
> From: Harvey Harrison <>
> Date: Wed, 15 Oct 2008 17:15:19 -0700
> > This has no functional changes, but annotates the code to make
> > the endianness more clear. In addition, removes some of the only
> > users of cpu_to_le[16|32]p in the kernel.
> >
> > Signed-off-by: Harvey Harrison <>
> Remind me what the problem is with cpu_to_{le,be}*()?

Nothing inherently wrong with them, other than it seems that nearly
every user (not this one) would be better served using the by-value

> The interface names define a direction, which in this case is
> "CPU endianness to BE/LE endianness". And that is exactly
> what is happening in the out*() routines.
> This aids comprehension of the code and is quite useful IMHO.

Yes, and even from that angle I think my patch is more instructive to
understanding the direction, compare for example in the same file
outsw versus outsl which this patch changes.


 \ /
  Last update: 2008-10-16 02:35    [W:0.042 / U:6.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site