lkml.org 
[lkml]   [2008]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC Patch 3/9] Modifying generic debug exception to use virtual debug registers
    Date
    You need to redo this (and the whole set) for the post-2.6.27 tree.
    e.g. traps.c has been unified.

    + /* Store the virtualized DR6 value */
    + tsk->thread.vdr6 = dr6;
    +
    + if (notify_die(DIE_DEBUG, "debug", regs, dr6, error_code,
    + SIGTRAP) == NOTIFY_STOP)
    return;

    I'm not sure you should change vdr6 when notify_die returns NOTIFY_STOP.
    Maybe Alan and I hashed out the logic of this before, I don't recall.
    If the notifier is eating the event, then it should not affect the
    thread-virtualized view of %db6. That would be consistent with the
    existing code, where ->thread.debugreg6 is only set later when all the
    intercepted or spurious exceptions have been filtered out.


    Thanks,
    Roland


    \
     
     \ /
      Last update: 2008-10-16 02:29    [W:4.457 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site