lkml.org 
[lkml]   [2008]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] sparc64: Annotate pointers in PeeCeeI.c
From
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Wed, 15 Oct 2008 17:15:19 -0700

> This has no functional changes, but annotates the code to make
> the endianness more clear. In addition, removes some of the only
> users of cpu_to_le[16|32]p in the kernel.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>

Remind me what the problem is with cpu_to_{le,be}*()?

The interface names define a direction, which in this case is
"CPU endianness to BE/LE endianness". And that is exactly
what is happening in the out*() routines.

This aids comprehension of the code and is quite useful IMHO.


\
 
 \ /
  Last update: 2008-10-16 02:27    [W:0.038 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site