Messages in this thread | | | Date | Wed, 15 Oct 2008 15:11:19 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH -mm -v5] Separate atomic_t declaration from asm/atomic.h into asm/atomic_def.h |
| |
On Tue, 14 Oct 2008 12:47:19 -0600 Matthew Wilcox <matthew@wil.cx> wrote:
> On Fri, Oct 10, 2008 at 03:54:50PM -0700, Andrew Morton wrote: > > I have a note here that Matthew has proposed a different way of doing > > all this. I don't immediately recall the details. > > > > Can we get a refresh on all of that please? > > I didn't remember either, but having just reviewed my inbox from August, > I said that all architectures basically use: > > typedef struct { volatile int counter; } atomic_t; > #ifdef CONFIG_64BIT > typedef struct { volatile long counter; } atomic64_t; > #endif > > and that should just be put in <linux/atomic_types.h>. > > Roman Zippel did me one better and suggested just putting it in types.h, > which works for me.
OK. Or we could do the usual include/asm-generic/atomic_types.h and then architectures can choose to include that if it is appropriate.
Anyway the good news is that this concept is an addition to rather than a replacement of this current patch.
| |