Messages in this thread | | | Date | Wed, 15 Oct 2008 16:20:19 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH 4/6] vfs: remove unnecessary fsnotify_d_instantiate() |
| |
On Thu, Oct 16, 2008 at 05:16:58AM +0900, OGAWA Hirofumi wrote: > Christoph Hellwig <hch@infradead.org> writes: > > > On Wed, Oct 15, 2008 at 10:58:11PM +0900, OGAWA Hirofumi wrote: > >> > >> This calls d_move(), so fsnotify_d_instantiate() is unnecessary like > >> rename path. > > > > fsnotify_d_instantiate and fsnotify_d_move call into different inotify > > functions. Did you verify that this really does the right thing? > > (Sorry, not in a mood to look into idiotify code..) > > Yes. I checked it.
Then the patch looks good to me.
| |