lkml.org 
[lkml]   [2008]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] HID: fix default building of all quirky devices
On Wed, Oct 15, 2008 at 10:17:27AM -0700, Linus Torvalds wrote:
>
>
> On Wed, 15 Oct 2008, Linus Torvalds wrote:
> >
> > And notice how you mis-use select. That's not how to disable a question. A
> > question gets disabled by just doing an "if xyz" on the question itself,
> > like Adrian did.
>
> Side note: Adrian too has a very odd and non-obvious way of doing this.
>
> His patch did config entries like
>
> config HID_BRIGHT
> tristate "Bright" if EMBEDDED
> default USB_HID
> depends on USB_HID
>
> which is a really odd way to express this. The much more natural one is
>
> config HID_BRIGHT
> tristate "Bright" if EMBEDDED
> depends on USB_HID
> default y
>
> since there's no point in saying "default USB_HID" + "depends on USB_HID",
> and that's just confusing. Since it depends on USB_HID, the "default y"
> will automatically degrade to whatever USB_HID was set to.

For me the more obvious way was what I did, but I agree that your
solution looks better.

> Linus

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed



\
 
 \ /
  Last update: 2008-10-15 19:35    [W:0.100 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site