lkml.org 
[lkml]   [2008]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: GIT head no longer boots on x86-64


On Wed, 15 Oct 2008, Ingo Molnar wrote:
>
> Queued the fix below up in tip/x86/urgent for a merge to Linus later
> today. Thanks!

Please don't send this crap to me.

Guys, _look_ at the patch for one second. And then tell me it isn't crap.

The question is: "Is this a vmalloc'ed area?". That's the name of the
function. AND YOU JUST BROKE IT!

Fix the damn caller instead. Don't make x86-64-specific changes to a
generic function that breaks the whole meaning of the function. I don't
understand what the hell is wrong with you people - we don't fix bugs by
introducing idiocies, we fix them by fixing the code.

EVEN YOUR COMMIT MESSAGE should have made this obvious.

The code in question already does

VIRTUAL_BUG_ON(!is_vmalloc_addr(vmalloc_addr) &&
!is_module_address(addr));

and look at that thing and ask yourself: where was the bug again.

And dammit, if you say it was in "is_vmalloc_addr()", I can only shake my
head.

Please guys. Use some taste.

Linus


\
 
 \ /
  Last update: 2008-10-15 17:09    [W:0.131 / U:12.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site