lkml.org 
[lkml]   [2008]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: origin tree build failure


On Wed, 15 Oct 2008, Stephen Rothwell wrote:
>
> +#ifndef NO_IRQ
> +#define NO_IRQ 0
> +#endif

Btw, as to why not do this idiocy, just grep for it.

We have several drivers that try to do something this stupid. Don't take
my word for it? Look for them. And see them do things like

- drivers/scsi/arm/fas216.h:

#ifndef NO_IRQ
#define NO_IRQ 255
#endif

- drivers/pcmcia/pd6729.c (really interesting):

#ifndef NO_IRQ
#define NO_IRQ ((unsigned int)(0))
#endif

- drivers/rtc/rtc-m48t59.c:

#ifndef NO_IRQ
#define NO_IRQ (-1)
#endif

so please don't add yet another version to the insanity. Just mark
anything with NO_IRQ as BROKEN or ARM-specific, or something.

Linus


\
 
 \ /
  Last update: 2008-10-15 01:55    [from the cache]
©2003-2011 Jasper Spaans