Messages in this thread | | | Date | Mon, 13 Oct 2008 18:04:20 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] Fix broken debug output reserve_region_with_split() |
| |
Benjamin Herrenschmidt wrote: > That debug outpout in kernel/resource.c is busted on 32-bit > machines, fix it with appropriate casts. > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > --- > > One day Yinghai will figure out that resource_size_t can be 32-bit > and thus as printk arguments must be cast to (unsigned long long) > explicitely when using %llx... hopefully, that day, Ingo will also > catch these before committing them as it's not the first one like > this :-) >
I really think Linus' solution (add a resource printf modifier, that can contain the whole format) is much better.
-hpa
| |