lkml.org 
[lkml]   [2008]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] pata_of_platform: fix no irq handling
    From
    Date
    On Mon, 2008-10-13 at 15:56 +0900, Tejun Heo wrote:
    > Anton Vorontsov wrote:
    > > When no irq specified the pata_of_platform fills the irq_res with -1,
    > > which is wrong to do for two reasons:
    > >
    > > 1. By definition, 'no irq' should be IRQ 0, not some negative integer;
    > > 2. pata_platform checks for irq_res.start > 0, but since irq_res.start
    > > is unsigned type, the check will be true for `-1'.
    > >
    > > Reported-by: Steven A. Falco <sfalco@harris.com>
    > > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
    >
    > applied to #tj-upstream (will soon be sent upstream)

    Hrm... I applied it to powerpc.git too :-) Hopefully the merge will sort
    it out !

    Cheers,
    Ben.




    \
     
     \ /
      Last update: 2008-10-14 01:35    [W:0.046 / U:4.944 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site