Messages in this thread | | | Subject | Re: SLUB defrag pull request? | From | Miklos Szeredi <> | Date | Mon, 13 Oct 2008 16:28:43 +0200 |
| |
On Mon, 13 Oct 2008, Christoph Lameter wrote: > Miklos Szeredi wrote: > > I think it's wrong to unhash dentries while they are possibly still > > being used. You can do the shrink_dcache_parent() here, but should > > leave the unhashing to be done by prune_one_dentry(), after it's been > > checked that there are no other users of the dentry. > > > > > d_invalidate() calls shrink_dcache_parent() as needed and will fail if > there are other users of the dentry.
Only if it's a directory. Now unhashing an in-use non-directory is not fatal, but you'll get things like "filename (deleted)" in /proc, and suchlike. Don't do it.
Miklos
| |