Messages in this thread |  | | Date | Mon, 13 Oct 2008 18:14:49 +0400 | From | Evgeniy Polyakov <> | Subject | Re: Distributed storage release. |
| |
Hi Pekka.
On Mon, Oct 13, 2008 at 04:44:28PM +0300, Pekka Enberg (penberg@cs.helsinki.fi) wrote: > > What's the difference? In saving one space and replacing another with > > comma? I do not particulary care, but would like to know why it is > > needed :) > > kcalloc() will check for multiplication overflow which is nice > especially if size is passed from user-space (not sure if that applies > here).
I think that 32-bit overflow check during multiplication in allocation code is the last thing to worry about :) If this parameters are not checked before, we are screwd already...
P.S. DST does not check one of them, oops.
-- Evgeniy Polyakov
|  |