lkml.org 
[lkml]   [2008]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cifs: fix build on !CONFIG_KEYS
On Sun, 12 Oct 2008 13:30:48 +0200
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:

> On Sunday, 12 of October 2008, Steven Noonan wrote:
> > Hmm, which fix is correct though? Depending on KEYS in Kconfig, or
> > adding a nop for it?
>
> Well, according to git-blame the key_revoke() has been added to fs/cifs/sess.c
> only recently while key_put() was there before. For this reason I think it's
> correct to handle key_revoke() in analogy with key_put(), ie. add an empty
> definition for it if CONFIG_KEYS is unset.
>
> Thanks,
> Rafael
>

Agreed. It should be possible to build CIFS w/o KEYS support. Adding an empty
key_revoke looks like the right thing to do. Looks like Adrian Bunk sent a
patch for this a few hours ago:

Subject: [2.6 patch] add key_revoke() dummy for KEYS=n

--
Jeff Layton <jlayton@redhat.com>


\
 
 \ /
  Last update: 2008-10-12 13:33    [W:0.028 / U:5.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site