lkml.org 
[lkml]   [2008]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/1] Ath9k: fix uninitialized value in ath9k_hw_reset
From
From: Jiri Slaby <jirislaby@gmail.com>
Date: Fri, 10 Oct 2008 19:56:43 +0200

> status ath9k_hw_reset() parameter should be set in every case, since
> it is used in callers to find out an error code.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> Cc: Luis R. Rodriguez <lrodriguez@atheros.com>
> Cc: Jouni Malinen <jmalinen@atheros.com>
> ---
> drivers/net/wireless/ath9k/hw.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath9k/hw.c b/drivers/net/wireless/ath9k/hw.c
> index 62e44a0..fb6727b 100644
> --- a/drivers/net/wireless/ath9k/hw.c
> +++ b/drivers/net/wireless/ath9k/hw.c
> @@ -5893,7 +5893,7 @@ bool ath9k_hw_reset(struct ath_hal *ah,
> }
>
> if (!ath9k_hw_setpower(ah, ATH9K_PM_AWAKE))
> - return false;
> + FAIL(-EIO);
>

This fix may be correct, but this is the first time I've noticed
these error status updating macros and they are super ugly.

I really think they should be removed. Someone casually scanning
this code won't be able to discern the side effects and that makes
auditing harder and more error prone.


\
 
 \ /
  Last update: 2008-10-10 20:57    [W:0.040 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site