Messages in this thread | | | Date | Fri, 10 Oct 2008 09:19:25 -0700 (PDT) | Subject | Re: [PATCH 22/27] serial: Make uart_port's ioport "unsigned long". | From | David Miller <> |
| |
From: Josh Boyer <jwboyer@gmail.com> Date: Fri, 10 Oct 2008 08:54:34 -0400
> On Fri, Oct 10, 2008 at 11:50:56AM +0100, Alan Cox wrote: > >From: David Miller <davem@davemloft.net> > > > >Otherwise the top 32-bits of the resource value get chopped > >off on 64-bit systems, and the resulting I/O accesses go to > >random places. > > > >Thanks to testing and debugging by Josip Rodin, which helped > >track this down. > > > >Signed-off-by: David S. Miller <davem@davemloft.net> > >Signed-off-by: Alan Cox <alan@redhat.com> > > I emailed on an earlier posting of this about using resource_size_t > instead as we have 32-bit CPUs with 64-bit address spaces. If I'm > totally wrong, that's fine but I'm still wondering if that would be > a better general solution.
That seems like a fine idea to me, please post a follow-on patch if you like :-)
| |