lkml.org 
[lkml]   [2008]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ftrace: Make ftrace_test_p6nop disassembler-friendly

On Fri, 10 Oct 2008, Ingo Molnar wrote:

>
> * Anders Kaseorg <andersk@MIT.EDU> wrote:
>
> > Commit 4c3dc21b136f8cb4b72afee16c3ba7e961656c0b in tip introduced the
> > 5-byte NOP ftrace_test_p6nop:
> > jmp . + 5
> > .byte 0x00, 0x00, 0x00
> > This is not friendly to disassemblers because an odd number of 0x00s
> > ends in the middle of an instruction boundary. This changes the 0x00s
> > to 1-byte NOPs (0x90).
> >
> > Signed-off-by: Anders Kaseorg <andersk@mit.edu>
>
> applied to tip/tracing/ftrace, good spotting Anders!
>
> Steve, any objections?

Nope, it's fine with me.

Acked-by: Steven Rostedt <srostedt@redhat.com>



\
 
 \ /
  Last update: 2008-10-10 15:31    [W:0.191 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site