Messages in this thread | | | Date | Fri, 10 Oct 2008 09:27:34 -0400 (EDT) | From | Steven Rostedt <> | Subject | Re: [PATCH] ftrace: Make ftrace_test_p6nop disassembler-friendly |
| |
On Fri, 10 Oct 2008, Ingo Molnar wrote:
> > * Anders Kaseorg <andersk@MIT.EDU> wrote: > > > Commit 4c3dc21b136f8cb4b72afee16c3ba7e961656c0b in tip introduced the > > 5-byte NOP ftrace_test_p6nop: > > jmp . + 5 > > .byte 0x00, 0x00, 0x00 > > This is not friendly to disassemblers because an odd number of 0x00s > > ends in the middle of an instruction boundary. This changes the 0x00s > > to 1-byte NOPs (0x90). > > > > Signed-off-by: Anders Kaseorg <andersk@mit.edu> > > applied to tip/tracing/ftrace, good spotting Anders! > > Steve, any objections?
Nope, it's fine with me.
Acked-by: Steven Rostedt <srostedt@redhat.com>
| |