lkml.org 
[lkml]   [2008]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/6] Tracing/fastboot: Enable boot tracing only during initcalls
    From
    Ingo Molnar wrote:
    > * Frédéric Weisbecker <fweisbec@gmail.com> wrote:
    >
    >> 2008/10/10 Ingo Molnar <mingo@elte.hu>:
    >>> * Frederic Weisbecker <fweisbec@gmail.com> wrote:
    >>>
    >>>> We used to disable the initcall tracing at a specified time (IE: end
    >>>> of builtin initcalls). But we don\'t need it anymore. It will be
    >>>> stopped when initcalls are finished. However we want two things:
    >>>>
    >>>> _Start this tracing only after pre-smp initcalls are finished. _Since
    >>>> we are planning to trace sched_switches at the same time, we want to
    >>>> enable them only during the initcall execution. For this purpose, this
    >>>> patch introduce two functions to enable/disable the sched_switch
    >>>> tracing during boot.
    >>>>
    >>>> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
    >>> applied to tip/tracing/fastboot, thanks Frederic!
    >>>
    >>> Ingo
    >>>
    >> Oops, sorry Ingo there are some backslashes that taint this patch.
    >> I will resend a V2....
    >
    > dont worry, i fixed them already when i applied your patch (and that's
    > all in latest tip/master).
    >
    > See the commit below - i sanitize most commit entries to make subject
    > lines more consistent (note the capitalization difference between your
    > submission and the end result), to improve paragraphing and general
    > structure.

    You missed the one backslash though...

    > -/* Should be started after do_pre_smp_initcalls() in init/main.c */
    > +/* Tells the boot tracer that the pre_smp_initcalls are finished.
    > + * So we are ready .
    > + * It doesn\'t enable sched events tracing however.
    > + * You have to call enable_boot_trace to do so.
    > + */

    Alan
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-10-10 14:57    [W:0.022 / U:31.160 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site