Messages in this thread Patch in this message | | | From | Steven Noonan <> | Subject | [PATCH] drivers/serial/8250.c: 'i' may be used uninitialized | Date | Wed, 1 Oct 2008 01:47:07 -0700 |
| |
serial_unlink_irq_chain() does not initialize iterator 'i', and that is correct logically because it is always initialized, either in the hlist_for_each or in the conditional immediately after (which fires if hlist_for_each comes up empty-handed). GCC does not realize this connection and emits a false warning. Annotate it with uninitialized_var().
Signed-off-by: Steven Noonan <steven@uplinklabs.net> --- drivers/serial/8250.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index 356c2a2..4950ee5 100644 --- a/drivers/serial/8250.c +++ b/drivers/serial/8250.c @@ -1551,7 +1551,7 @@ static int serial_link_irq_chain(struct uart_8250_port *up) { struct hlist_head *h; struct hlist_node *n; - struct irq_info *i; + struct irq_info *uninitialized_var(i); int ret, irq_flags = up->port.flags & UPF_SHARE_IRQ ? IRQF_SHARED : 0; mutex_lock(&hash_mutex); -- 1.6.0.2
| |